I started working over this one in my 'Save all' button branch as my second ever bug to be fixed for Empathy but insufficient experience in asynchronous programming and debugging caused it to stand by. This week I went back to it and with the past one month's experience, it was all play!
Here's a shot.
This "Save all" button will be useful when users face issues and are unsure of what part is causing a particular problem. It could be the connection managers, mission-control or parts of Empathy itself. So with this branch merged, instead of saving individual logs for each service selected using the service chooser, one will need to simply use this button and have a compiled log saved on disk.
I made another not much observable change in this branch too. The older save button used to fetch log messages from the model which was updated from the cache and was used to display the messages in the main view. To make both saving tasks work coherently and to avoid code reuse, I changed it to load messages directly from the cache like what our new "Save all" button does.
There was this another bug evident using telepathy-gabble 0.11.5, about which I also mentioned in my last post, where, in MUC chat window tabs the typing icon was not getting correctly updated [bug]. I begun with a patch for it but after discussing it over IRC, finally closed it as the typing icon in MUCs is no more relevant when the typing icon is displayed next to the composers now.
No comments:
Post a Comment